Adjust config detail default tab ordering #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the default tab ordering and routing for config detail pages by redirecting the catalog base URL to the first available tab and prioritizing config-attached views over static tabs.
- Implements automatic redirection to the first available tab when accessing catalog config base URLs
- Reorders tabs to surface config-attached views before static tabs and respects ordinal ordering
- Renames the "Catalog" tab to "Spec" and updates routing accordingly
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/config/details/ConfigDetailsIndexRedirect.tsx | New redirect component that automatically navigates to the first available tab |
| src/components/Configs/ConfigTabsLinks.tsx | Reorders tabs to prioritize views, adds ordinal sorting, and renames Catalog to Spec |
| src/pages/config/details/ConfigDetailsPage.tsx | Updates active tab name from "Catalog" to "Spec" |
| src/components/Configs/ConfigDetailsTabs.tsx | Updates type definitions and default values for the renamed tab |
| src/api/services/views.ts | Adds ordinal field to ViewListItem type |
| src/App.tsx | Adds routing for the new redirect component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves: #2639